Fix switch_on_hover for MenuButton

[Sauermann]

Previously, embedded Windows (the opened menu) were not accounted for when checking for switch_on_hover.

gui_get_hovered_control() is more appropriate to check for the hover status of other MenuButton nodes at the mouse position.

Explain the usage of the incorrectly used function in a comment.

• resolve MenuButton's switch_on_hover property ignores its own popup menu. #99842

[Geometror]

Looks good! Tested locally and I can confirm that this fixes the linked issue.

Edit: Maybe gui_find_control should be fixed to handle (embedded) subwindows since the former comment implies that this is a bug, but that can be done separately from this PR.

[Sauermann]

Maybe gui_find_control should be fixed to handle (embedded) subwindows since the former comment implies that this is a bug, but that can be done separately from this PR.

I would prefer to not make such a change, because currently this function is used only in Viewport::_gui_input_event and Viewport::_update_mouse_over and as far as I can tell in both functions it is made sure, that there is no Window at that position. So checking for embedded windows in gui_find_control would make that function more complex, while the added complexity is currently not needed.

[akien-mga]

Thanks!