Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] C#: Fix incorrect Rect2 sizing when using the Transform2D * operator. #86466

Merged

Conversation

andy-noisyduck
Copy link
Contributor

The * operator incorrectly calculates Rect2 sizes when the applied Transform2D has a negative component.

Was fixed in master as part of #64729, but not separately backported. Fixes #86415.

@raulsntos raulsntos added this to the 3.6 milestone Dec 23, 2023
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much for finding and fixing the issue.

@raulsntos raulsntos linked an issue Dec 23, 2023 that may be closed by this pull request
@raulsntos raulsntos added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 23, 2023
@akien-mga akien-mga changed the title C#: Fix incorrect Rect2 sizing when using the Transform2D * operator. [3.x] C#: Fix incorrect Rect2 sizing when using the Transform2D * operator. Jan 5, 2024
@akien-mga akien-mga merged commit fd93036 into godotengine:3.x Jan 5, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.4.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rect2 * Transform2D broken in 3.x LTS for C#
4 participants