C#: Replace Xform and XformInv with * operator
#64729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
Aug 22, 2022
| @@ -552,11 +527,11 @@ public Transform2D(real_t rotation, Vector2 origin) | |||
| Vector2 to2 = new Vector2(rect.Position.x + rect.Size.x, rect.Position.y + rect.Size.y) * transform; | |||
| Vector2 to3 = new Vector2(rect.Position.x + rect.Size.x, rect.Position.y) * transform; | |||
|
|
|||
| return new Rect2(pos, rect.Size).Expand(to1).Expand(to2).Expand(to3); | |||
| return new Rect2(pos, new Vector2()).Expand(to1).Expand(to2).Expand(to3); | |||
There was a problem hiding this comment.
This is a separate bug fix. It looks good, but it's questionable to sneak this in with Xform refactor.
There was a problem hiding this comment.
You are right, I thought since I was modifying all the Xform methods and I noticed this difference with the C++ implementation it might make sense to include it rather than create a separate PR but probably should extract it.
There was a problem hiding this comment.
I'm fine with it being in this PR, or another, but it should at least be mentioned in the PR description.
- In cases where both `Xform`/`XformInv` and the `*` operator were implemented the `Xform`/`XformInv` methods were removed in favor of the `*` operator. - In cases where the `Xform`/`XformInv` existed but not the `*` operator, the `Xform`/`XformInv` methods were replaced with the `*` operator. - In cases where no method existed, a new `*` operator has been implemented to support the same operations that are supported in GDScript. - Fixes the `Transform.Xform` and `Transform.XformInv` with `Rect2` implementation to use a zero `Rect2` size to start expanding from (which is how it's implemented in C++).
raulsntos
force-pushed
the
csharp-xform-operator
branch
from
90f8e21 to
0b8b733
Compare
|
Is it the same as GDScript? Was xform replaced with operators there? |
|
Yes. |
neikeq
approved these changes
Aug 22, 2022
|
Thanks! |
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xform/XformInvand the*operator were implemented theXform/XformInvmethods were removed in favor of the*operator.Xform/XformInvexisted but not the*operator, theXform/XformInvmethods were replaced with the*operator.*operator has been implemented to support the same operations that are supported in GDScript.Transform.XformandTransform.XformInvwithRect2implementation to use a zeroRect2size to start expanding from (which is how it's implemented in C++).