-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant non-trivial Variant types initializations #68657
Remove redundant non-trivial Variant types initializations #68657
Conversation
While at it, there's also:
And some more for other types, e.g.
And all other non-trivial Variant types such as |
I can simply rename the PR to "Remove redundant initialization" to change the scope ;-) |
2ef5d3e
to
3b14f03
Compare
@@ -420,7 +420,7 @@ void AnimationNodeStateMachineEditor::_state_machine_gui_input(const Ref<InputEv | |||
if (mm.is_valid()) { | |||
state_machine_draw->grab_focus(); | |||
|
|||
String new_over_node = StringName(); | |||
String new_over_node; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initializing a String
with StringName()
was probably not intentional.
Thanks! |
As mentioned in #68627 (comment).