Fix position of Tooltips

[Sauermann]

resolve #65947

CanvasItem::get_screen_transform returns a transform from the CanvasItem to the coordinate system, where a Popup - created as a child of the CanvasItem - should be opened.
CanvasItem::get_screen_transform makes some simplifications, that work well, when used in the editor, but not in general cases.

Since Popups like Tooltips are now used more commonly in projects, it becomes necessary to correct these simplifications.

This solution introduces Viewport::get_popup_base_transform, which makes the necessary calculations.

The next time, user-facing-function-renames are possible CanvasItem::get_screen_transform should be renamed to CanvasItem::get_popup_transform.

MRP: BugPopupTransform.zip

Before and after:

BugHoverTooltip.mp4

SolutionHoverTooltip.mp4

[akien-mga]

The next time, user-facing-function-renames are possible CanvasItem::get_screen_transform should be renamed to CanvasItem::get_popup_transform.

We can still do renames now if they're important enough. If this helps clean the API and reduce confusion, it's probably best done now than waiting for 5.0.

[Sauermann]

We can still do renames now if they're important enough. If this helps clean the API and reduce confusion, it's probably best done now than waiting for 5.0.

@akien-mga Confusion might arise between

• Viewport.get_screen_transform: returns a transform to the actual Window-Manager screen
• CanvasItem.get_screen_transform: returns a transform to the location of the popup (and is influenced by Viewports and if they are configured to embed windows) and might not even be on the Window-Manager screen

This name-change should include CanvasItem.get_screen_position and CanvasItem.get_screen_rect which both behave like CanvasItem.get_screen_transform.

If there is consensus, that these three name-changes (CanvasItem.get_screen_* to CanvasItem.get_popup_*) are important enough to make it into 4.0, then I would create a PR for that change.

[groud]

Would this PR fix #71327 ?

[Sauermann]

@groud I am not sure.
Your linked issue shows a problem with multiple displays and this PR doesn't explicitely adress multi-display-functionality.
At the moment I don't have access to multiple displays in order to give a verified answer.

[groud]

Approved in PR meeting. Needs get_popup_transform to be renamed get_base_popup_transform though.

[akien-mga]

Approved in PR meeting. Needs get_popup_transform to be renamed get_base_popup_transform though.

Or get_popup_base_transform? :D

Changes done.

[akien-mga]

Thanks!