Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix ParticlesMaterial spread. #47310

Merged

Conversation

mortarroad
Copy link
Contributor

Same as #47228, but rebased for 3.x.

@mortarroad mortarroad force-pushed the 3.x-fix-particles-material-spread branch from 3a656e1 to e06b096 Compare March 25, 2021 16:27
@mortarroad mortarroad changed the title [3.x] Fix ParticlesMaterial spread and add spread_normal attribute. [3.x] Fix ParticlesMaterial. Mar 25, 2021
@mortarroad mortarroad changed the title [3.x] Fix ParticlesMaterial. [3.x] Fix ParticlesMaterial spread. Mar 25, 2021
@mortarroad
Copy link
Contributor Author

Is anything blocking this for 3.x?

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it was just waiting for 3.3 to release so it could be merged into 3.4. Thanks for the reminder.

@akien-mga This should be good for 3.4, but not for 3.3.1 because technically it is a slight change to behaviour

@akien-mga akien-mga merged commit 39826d3 into godotengine:3.x May 11, 2021
@akien-mga
Copy link
Member

Thanks!

@mortarroad mortarroad deleted the 3.x-fix-particles-material-spread branch May 22, 2021 22:56
mortarroad added a commit to mortarroad/godot that referenced this pull request Aug 12, 2021
mortarroad added a commit to mortarroad/godot that referenced this pull request Aug 12, 2021
Fixes godotengine#51162
This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
sairam4123 pushed a commit to sairam4123/godot that referenced this pull request Nov 10, 2021
sairam4123 pushed a commit to sairam4123/godot that referenced this pull request Nov 10, 2021
Fixes godotengine#51162
This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this pull request Dec 18, 2021
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this pull request Dec 18, 2021
Fixes godotengine#51162
This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants