-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Fix ParticlesMaterial spread. #47310
Merged
akien-mga
merged 1 commit into
godotengine:3.x
from
mortarroad:3.x-fix-particles-material-spread
May 11, 2021
Merged
[3.x] Fix ParticlesMaterial spread. #47310
akien-mga
merged 1 commit into
godotengine:3.x
from
mortarroad:3.x-fix-particles-material-spread
May 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortarroad
force-pushed
the
3.x-fix-particles-material-spread
branch
from
March 25, 2021 16:27
3a656e1
to
e06b096
Compare
mortarroad
changed the title
[3.x] Fix ParticlesMaterial spread and add spread_normal attribute.
[3.x] Fix ParticlesMaterial.
Mar 25, 2021
mortarroad
changed the title
[3.x] Fix ParticlesMaterial.
[3.x] Fix ParticlesMaterial spread.
Mar 25, 2021
Is anything blocking this for 3.x? |
clayjohn
approved these changes
May 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it was just waiting for 3.3 to release so it could be merged into 3.4. Thanks for the reminder.
@akien-mga This should be good for 3.4, but not for 3.3.1 because technically it is a slight change to behaviour
Thanks! |
mortarroad
added a commit
to mortarroad/godot
that referenced
this pull request
Aug 12, 2021
mortarroad
added a commit
to mortarroad/godot
that referenced
this pull request
Aug 12, 2021
Fixes godotengine#51162 This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
sairam4123
pushed a commit
to sairam4123/godot
that referenced
this pull request
Nov 10, 2021
sairam4123
pushed a commit
to sairam4123/godot
that referenced
this pull request
Nov 10, 2021
Fixes godotengine#51162 This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
lekoder
pushed a commit
to KoderaSoftwareUnlimited/godot
that referenced
this pull request
Dec 18, 2021
lekoder
pushed a commit
to KoderaSoftwareUnlimited/godot
that referenced
this pull request
Dec 18, 2021
Fixes godotengine#51162 This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #47228, but rebased for 3.x.