Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPUParticles: setting direction.y zeroes direction.x unless direction.z is non-zero #51162

Closed
cptchuckles opened this issue Aug 2, 2021 · 2 comments

Comments

@cptchuckles
Copy link
Contributor

cptchuckles commented Aug 2, 2021

Godot version

3.3.2-stable

System information

Artix Linux 5.12.12 :: i7-9750H 16GB GeForce 1650 Max-Q :: GLES 3

Issue description

Changing a CPUParticle's direction.y to anything other than zero will cause it to emit only along the Y-axis, even if direction.x is non-zero, except both direction.x and direction.z are non-zero.

Here is a video (link):
Watch the video

Steps to reproduce

Create a CPUParticle, give it a basic mesh
Set the Direction X to something
Then change Direction Y
Observe that the particle emits exclusively on the Y-axis.
Then change Direction Z
Observe that the Direction X value is once again respected

Minimal reproduction project

Here is the test scene from the video

main.tscn

[gd_scene load_steps=2 format=2]

[sub_resource type="CubeMesh" id=1]
size = Vector3( 0.2, 0.2, 0.2 )

[node name="main" type="Spatial"]

[node name="CPUParticles" type="CPUParticles" parent="."]
mesh = SubResource( 1 )
direction = Vector3( 11.706, 0, 0 )
spread = 0.0
initial_velocity = 3.35
@akien-mga
Copy link
Member

Confirmed in 8f3ec04.

(GPU) Particles don't seem to have this issue on the other hand.

@akien-mga akien-mga added this to the 3.4 milestone Aug 2, 2021
mortarroad added a commit to mortarroad/godot that referenced this issue Aug 12, 2021
Fixes godotengine#51162
This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
@akien-mga
Copy link
Member

Fixed by #51565.

sairam4123 pushed a commit to sairam4123/godot that referenced this issue Nov 10, 2021
Fixes godotengine#51162
This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
lekoder pushed a commit to KoderaSoftwareUnlimited/godot that referenced this issue Dec 18, 2021
Fixes godotengine#51162
This is the same change as for the GPU Particles in godotengine#47310, including the recent fix for zero direction vectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants