Fix for regression in SkeletonIK code #47147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
cherrypick:3.x
akien-mga
approved these changes
Mar 18, 2021
|
Thanks! |
|
Cherry-picked for 3.3. |
akien-mga
removed
the
cherrypick:3.x
|
I'm sorry the issue still there, please reopen the issue @akien-mga |
TwistedTwigleg
deleted the
skeletonik_changes_and_bug_fixes_regressionfix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #47086. I tested the included example project and it seemed to work as expected with this PR.
I also tried another project with scaled meshes and everything still works there as well.
I was not able to test the visual results though, as any 3D model I imported didn't show the mesh and only showed the skeleton. I'm not sure if its something with the version of Master I rebased to, my graphics card, or something else.