Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.4 rc5] Skeleton Animation has different behavior when IK enable because the recent fix about SkeletonIK #47086

Closed
snougo opened this issue Mar 17, 2021 · 10 comments · Fixed by #47147

Comments

@snougo
Copy link

snougo commented Mar 17, 2021

Godot version:

3.2.4 rc5 offical

OS/device including version:

MacOS 10.14.6 intel GPU GLES3

Issue description:

3.2.4 rc4

rc4.mov

and 3.2.4 rc5

rc5.mov
rc5-2.mov

I guess the recent fix about SkeletonIK cause this problem #46910

Steps to reproduce:

Minimal reproduction project:

IK issue.zip

@snougo snougo changed the title [3.2.4 rc5] Skeleton Animtion has different behavior when IK enable because the recent fix about SkeletonIK [3.2.4 rc5] Skeleton Animtion has different behavior when IK enable because the recent fix about SkeletonIK(I guess) Mar 17, 2021
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Mar 17, 2021
@akien-mga
Copy link
Member

CC @TwistedTwigleg

@akien-mga akien-mga changed the title [3.2.4 rc5] Skeleton Animtion has different behavior when IK enable because the recent fix about SkeletonIK(I guess) [3.2.4 rc5] Skeleton Animation has different behavior when IK enable because the recent fix about SkeletonIK Mar 17, 2021
@TwistedTwigleg
Copy link
Contributor

Thanks for the report, I'll take a look.

At a glance, it looks like the issue is that the origin bone is being set to the bone rest position rather than the bone's current pose, which is why its in the correct position but is not moving when animated. That's my guess as to what is going on. I'll take a look once I have the time and see if I can get a PR that fixes the issue.

@snougo
Copy link
Author

snougo commented Mar 19, 2021

@TwistedTwigleg
I have a bad news, the new PR don't fix this issue, and I have reimported the animation model from blender to make sure it's not caused by the file itself, but didn't work, the issue still appeared.

then I disabled AnimationTree's active and using AnimationPlayer to check what's going on, see the below sceenshots

3.2.4 rc4
Screen Shot 2021-03-19 at 18 52 11

3.3 rc6
Screen Shot 2021-03-19 at 18 49 57

@akien-mga
Copy link
Member

That fix was merged after 3.3 RC 6 was built, it's not included in the release. You can test the latest artifacts from the 3.x however: https://github.com/godotengine/godot/runs/2147580417

@snougo
Copy link
Author

snougo commented Mar 19, 2021

@akien-mga oh, that make scene, I'm just too much haste to read the changes, sorry

@snougo
Copy link
Author

snougo commented Mar 30, 2021

@TwistedTwigleg the fix didn't completely solve the issue, see the video

3.3.rc7.mov

@TwistedTwigleg
Copy link
Contributor

@snougo - I think #47441 will fix this issue 👍

@snougo
Copy link
Author

snougo commented Mar 30, 2021

@TwistedTwigleg got it

@snougo
Copy link
Author

snougo commented Apr 14, 2021

just back to report this issue has be fixed in 3.3 rc9
@TwistedTwigleg 👍

@TwistedTwigleg
Copy link
Contributor

Awesome, thanks for checking 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants