Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent button "Items" from disapearing when editing node #28258

Closed
wants to merge 1 commit into from

Conversation

Amssat221
Copy link

@Amssat221 Amssat221 commented Apr 21, 2019

Fixes #28211

@MunWolf
Copy link
Contributor

MunWolf commented Apr 21, 2019

This just makes the make_visible method do nothing, this will break more things then it fixes...

@Chaosus Chaosus changed the title #28211 Prevent button "Items" from disapearing when editing node Prevent button "Items" from disapearing when editing node Apr 21, 2019
@Chaosus Chaosus added this to the 3.2 milestone Apr 21, 2019
@Amssat221
Copy link
Author

@MunWolf , I'm working on another approach to solve this issue

@Amssat221
Copy link
Author

@MunWolf
I believe this should fix the issue. Can I have your opinion on it?

@akien-mga akien-mga requested a review from YeldhamDev May 28, 2019 09:47
@YeldhamDev
Copy link
Member

YeldhamDev commented May 28, 2019

I can't tell for sure, but I don't feel this is the right way to fix this.

EDIT: And indeed it isn't, as it's not fixing the issue in my end.

@akien-mga
Copy link
Member

Closing then, as it does not fix the issue as per @YeldhamDev's comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptionButton "Items" button dissapear when other editor is active (e.g. Theme or AtlasTexture)
5 participants