Remove early return for cached resources in GDScript::set_path_cache()

[gofastlily]

Fix #99006

From what I understand the logic that was removed meant that if a script were cached, it would never set the path cache, just the path.

I believe removing that check and early exit to guarantee setting the path cache is the appropriate fix.

[RandomShaper]

The fix may have to do with that, but I'm not sure about potential regressions. The GDScript cache is built, as I understand it, as a parallel cache to the main ResourceCache. The fact that this function needed to be overridden makes me think there are some assumptions at play that may break. set_path_cache() was intended as a loophole so one could set the path of a resource without it being added to the resource cache. That was useful, for instance, if a resource was loaded with CACHE_MODE_IGNORE yet you were still interested in the path it was loaded from.

So, if set_path_cache() in GDScript actually puts the resource in the GDScript's own cache, again, I can't be sure about the potential unintended consequences of this change unless all the GDScript caching logic is revised. There are other issues that may need something as deep as that to be fixed, like #101018 (see my comment there).

[gofastlily]

Okay, thanks for the extra context! I'll do some more digging to try and see what's happening here.

[KoBeWi]

If this doesn't bring back #95909 then it's probably fine.

[KoBeWi]

Does not fix #101615, which is a regression from the same PR.

I tried testing #95909 and I can reproduce it with and without #96499 🤷‍♂️

[akien-mga]

Superseded by #102429. Thanks for the contribution!