Script reference is broken when script is moved in FileSystem dock

[KoBeWi]

Tested versions

4.4 beta1
Didn't test other versions, but probably a regression.

System information

W10

Issue description

When you have a script opened and then you move it to another directory, the script reference in the editor is broken. The internal path does not update, so re-focusing editor causes errors about missing file and trying to save the file will have no effect.

Steps to reproduce

1. Open a script file in script editor
2. In FileSystem dock, move the file to another directory
3. Open the moved file in external editor
4. In Godot, modify and save the still opened script
5. See in external editor that changes are not saved

Alternatively:
3. Unfocus and focus the editor
4. Error in output

Minimal reproduction project (MRP)

N/A

[Jordyfel]

Investigated a bit and something weird is going on.

The bug only happens if both the scene and its script are open. During the filesystem dock move, a scene reload is requested, which ends up asking the script editor to edit the script. When iterating over the already opened scripts in the script editor, the following check for whether the script is already open weirdly fails:

godot/editor/plugins/script_editor_plugin.cpp

Line 2564 in 0726d3c

if ((scr.is_valid() && se->get_edited_resource() == p_resource) || se->get_edited_resource()->get_path() == p_resource->get_path()) {

Try setting a breakpoint here and then moving the file, the debugger shows 2 different objects with different pointer addresses and refcounts. The path_cache value also differs. The object with the correct path is the one passed to the function, and the wrong path belongs to the object returned by se->get_edited_resource().

[KoBeWi]

It's another regression from #96499
CC @beev1s

[Jordyfel]

Investigated some more and I think that PR should be reverted.

It is difficult to pin down, but it seems that, by sometimes avoiding registration in ResourceCache, the scripts end up getting duplicated. Some codepaths assume that scripts will be in the ResourceCache, so it doesn't seem like a good idea to occasionally avoid it.

One of the reasons for duplication seems to be this getting skipped when moving (because the script is not in the ResourceCache)

godot/editor/filesystem_dock.cpp

Lines 1560 to 1577 in 1586c56

	// Rename all resources loaded, be it subresources or actual resources.
	List<Ref<Resource>> cached;
	ResourceCache::get_cached_resources(&cached);
	for (Ref<Resource> &r : cached) {
	String base_path = r->get_path();
	String extra_path;
	int sep_pos = r->get_path().find("::");
	if (sep_pos >= 0) {
	extra_path = base_path.substr(sep_pos, base_path.length());
	base_path = base_path.substr(0, sep_pos);
	}
	if (p_renames.has(base_path)) {
	base_path = p_renames[base_path];
	r->set_path(base_path + extra_path);
	}
	}

The set_path() call would normally update the path in the GDScriptCache, but it gets skipped, then if the scene the script is attached to is open, the scene reloads the script, which is not found in the GDScriptCache at the new path, then the script gets recompiled and duplicated.