Add support for thread naming on windows platform #100400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Dec 14, 2024
CrabNickolson
force-pushed
the
windows-thread-names
branch
from
a29f145 to
d967b06
Compare
CrabNickolson
force-pushed
the
windows-thread-names
branch
from
d967b06 to
d848835
Compare
|
@bruvzg Thanks, I have applied your suggestions. I missed that this is Win10 only. |
bruvzg
approved these changes
Dec 18, 2024
|
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements thread naming for windows. So
Thread::set_name()andOS::set_thread_name()should work on that platform now.It is mostly a copy of
thread_posix, except I didn't use a designated initializer forPlatformFunctions, since that causes a compilation error. I'm not sure why that even works inthread_posix, since designated initializers apparently are a C++20 feature.