-
-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Godot compile on FreeBSD
#100047
Make Godot compile on FreeBSD
#100047
Conversation
0d02549
to
d791e20
Compare
Yeah it's a bit hacky and would break in cross-compilation (if there's any cross-compilation toolchain that targets FreeBSD). |
d791e20
to
6bc80ef
Compare
So for the thirdparty code, I kept the changes as Akien mentioned, but also created a diff file in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Fixes #67838, well, at least it does build on my dedicated FreeBSD 12.4 VM.
Some issues however:
There are minor thirdparty code modifications, hopefully its acceptable.Committed the changed and also documented them in a diff file.Not a fan of having toSeems like the simplest solution for now.import sys
directly to specifically detect FreeBSD. Any other solution would be appreciated.I'll tackle OpenBSD on a separate PR once I have that set-up.