[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st buildsystem bugs batch #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear what is the actual max value that windows support, but despite their claim of it being 8191 we have been seeing failure with just 8150. (cherry picked from commit 395a4fc)
The `env.disabled_modules` and `methods.disable_module` weren't used anywhere so the first one was repurposed and the second just deleted Signed-off-by: Yevhen Babiichuk (DustDFG) <[email protected]> (cherry picked from commit 8e75e02)
(cherry picked from commit 1a082fd)
Due to how caches are accessed this cache is almost useless, it only matters if it is from the same branch or a base branch, and is identical between branches, so caching it just clutters the build cache (cherry picked from commit 9923268)
…s with newer MinGW SDKs. (cherry picked from commit c363e13)
(cherry picked from commit 1768a1b)
(cherry picked from commit 6bc80ef)
(cherry picked from commit 404383e)
(cherry picked from commit 800076a)
decryptedchaos
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildsystem Bug PRs:
PKEY_Device_FriendlyNameto avoid duplicate symbols with newer MinGW SDKs. godotengine/godot#99036FreeBSDgodotengine/godot#100047dwarf-4for clang builds on Windows. godotengine/godot#100270