Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit TileMap or TileSet after opening its shader #32002

Closed
bmolyneaux opened this issue Sep 6, 2019 · 12 comments · Fixed by #71770
Closed

Can't edit TileMap or TileSet after opening its shader #32002

bmolyneaux opened this issue Sep 6, 2019 · 12 comments · Fixed by #71770

Comments

@bmolyneaux
Copy link
Contributor

Godot version:
3.1

OS/device including version:
Windows 10 Pro 64-bit

Issue description:
Once you open a Shader on a TileMap, you can no longer modify the tiles. This happens because the Shader panel is shown instead of the TileMap panel. This persists even if you close and reopen Godot. It took me a while to figure out how to resume editing the TileMap, either by:
A. Remove the Shader from the TileMap; or
B. Collapse the Shader in the Inspector the navigate away and then back to editing the TileMap.

Steps to reproduce:

  1. Create a TileMap
  2. Add a ShaderMaterial to the TileMap
  3. Add a Shader to the ShaderMaterial
  4. Open the Shader

Minimal reproduction project:
TileMapShaderBug.zip

@Zireael07
Copy link
Contributor

I also had this issue, so big props for describing it (I couldn't figure out what I did wrong)

@akien-mga akien-mga added this to the 3.2 milestone Sep 23, 2019
@KoBeWi
Copy link
Member

KoBeWi commented Jan 12, 2020

Seems to have the same cause as #28211

The Shader Editor blocks the Tilemap Editor.

@Zireael07
Copy link
Contributor

Still an issue in 3.2.3 RC3 according to securas.

@MrPingouin
Copy link

I confirm the issue on Godot 3.3 stable official linux.

@Shoes01
Copy link

Shoes01 commented May 6, 2021

Might be interesting to note: if you add a Shader to the specific Tile (inside TilesetEditorContext > Selected Tile > Material), you are still able to edit the TileMap.

@golddotasksquestions
Copy link

@Shoes01 that's true, unfortunately in this case you no longer can access the Tileset bottom panel.
So your options are either not being able to draw cells, or edit the Tileset anymore which both suck as even as a workaround.

@Torguen
Copy link

Torguen commented Jul 9, 2021

This has been fixed in 3.3.2?
Well it works for me now, now I can edit the tilemap even though it has a shader.

2021-07-09.15-56-12.mp4

@KoBeWi
Copy link
Member

KoBeWi commented Jul 9, 2021

The issue is that you can't edit the tiles while the shader is unfolded. See the OP:

resume editing the TileMap, either by:
B. Collapse the Shader in the Inspector the navigate away and then back to editing the TileMap.

So it's still valid.

@Calinou
Copy link
Member

Calinou commented Jul 13, 2021

As a workaround, you may be able to save the shader to an external *.shader file and edit it using an external text editor.

@reduz
Copy link
Member

reduz commented Jan 11, 2023

Does this still happen after the shader editor refactor?

@KoBeWi
Copy link
Member

KoBeWi commented Jan 11, 2023

Yes.

@bmolyneaux
Copy link
Contributor Author

I realized that the best way to edit the TileSet after adding a shader to the TileMap is to just select the TileSet from the Inspector:
image
This will activate the TileSet editor.

I think this was made a bit more obvious by the visual changes to the inspector which more clearly highlight which resource is selected within the inspector.

It looks like the TileSet and TileMap editors are (normally) automatically enabled when a TileMap node is selected (regardless of whether the TileSet resource is). However they are not enabled if the Shader was previously selected. I think a reasonable fix would be to ensure that the TileSet and TileMap editors are still enabled when a TileMap node is selected, even if the Shader editor is the one that's active.

@Calinou Calinou changed the title Can't edit TileMap after opening its shader Can't edit TileMap or TileSet after opening its shader Jan 14, 2023
@groud groud moved this to To investigate in Tiles, Tiles, Tiles Jan 17, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 4.x Priority Issues Jan 22, 2023
@github-project-automation github-project-automation bot moved this from To investigate to Done in Tiles, Tiles, Tiles Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Done
10 participants