Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when create/load project. #11043

Closed
sezit opened this issue Sep 7, 2017 · 2 comments · Fixed by #11058
Closed

Crash when create/load project. #11043

sezit opened this issue Sep 7, 2017 · 2 comments · Fixed by #11058
Labels
bug confirmed topic:editor
Milestone
3.0

Comments

@sezit
Copy link

sezit commented Sep 7, 2017 •
edited
Loading

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10 x64 build from 06.09.2017

Issue description:
When in project manager create new project windows says that program crashes but editor work fine, and project manager still visible. Its looks like project start twice.
error
@sezit sezit changed the title [3.0] Crash when create/load project. [3.0 Alpha] Crash when create/load project. Sep 7, 2017
@Calinou
Copy link
Member

Calinou commented Sep 7, 2017 •
edited
Loading

I can confirm this with a debug (or release_debug) editor build of commit 5f0d367. Note that the project manager doesn't crash with this commit, it just freezes indefinitely after opening a project. In comparison, with this build, which is a few commits older, it crashes instead, but the editor still functions normally.

Backtrace:

Backtrace from Visual Studio

@mrawlingst
Copy link
Contributor

I can also confirm this issue. It happened to me twice with same build as sezit's.

@hpvb hpvb mentioned this issue Sep 7, 2017
Merged
hpvb added a commit to hpvb/godot that referenced this issue Sep 10, 2017
@hpvb
Don't set editor_hint true for project manager
390a202 
Due to this setting several callbacks get initialized but never used.
For instance void discoverer_callback(). This callback only initializes
the GDNativeSingletonDiscover *discoverer when called. This doesn't
happen in project manager and this in turn causes a call to
memdelete(NULL) which is invalid. This also seems to speed up startup a
little.

This fixes godotengine#11043 and fixes godotengine#10992
@akien-mga akien-mga changed the title [3.0 Alpha] Crash when create/load project. Crash when create/load project. Sep 12, 2017
@akien-mga akien-mga added this to the 3.0 milestone Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:editor
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Don't set editor_hint true for project manager hpvb/godot
4 participants
@Calinou @akien-mga @mrawlingst @sezit