Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of #603, I spent a bunch of time myself trying to understand what's going on and finding ways to optimize the situation. These changes have been cherry-picked from #609 as they should be in working condition and mergeable.
Changes
add
andfind_all
withreplace
and the values being lists. This gives equivalent multimap behavior but makes it more explicit and notably keeps the hashtable bucket sizes much smaller. For example, on a subset of 50 OpenSSL files, instead of maximum bucket length of 198, it now is 9.TODO