Do not allow to collect globals with duplicate identifiers in map #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stilscher
referenced
this pull request
Feb 28, 2022
sim642
reviewed
Feb 28, 2022
sim642
approved these changes
Mar 15, 2022
michael-schwarz
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general comparison for the incremental analysis (used for both, the cfg and ast comparison) assumes that globals have a unique identifier. But it is not warned if this is not the case. Instead, the incremental analysis run will often fail later on in
UpdateCil.mlbecauseList.iter2expects lists of the same length. This happened for example in goblint/bench#16.This PR only inserts a warning when globals with duplicate identifiers are found to make it easier for now to detect this problem. One could of course also think further about how to make the comparison robust against globals with the same name.