-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
root: support running authentik in subpath #8675
Conversation
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-975c93c35de136603739aef386afeca8323dda04
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s For arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-975c93c35de136603739aef386afeca8323dda04-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-975c93c35de136603739aef386afeca8323dda04 For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-975c93c35de136603739aef386afeca8323dda04-arm64 Afterwards, run the upgrade commands from the latest release notes. |
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
There probably are security implications with this, like other apps being able to access authentik's cookies. We should probably mention them in the documentation. |
Signed-off-by: Jens Langhammer <[email protected]>
Oh yeah, I had this set when initially testing but it must've gotten removed at some point: 06723cb |
Co-authored-by: Marc 'risson' Schmitt <[email protected]> Signed-off-by: Jens L. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it myself, but looks ok. I do wonder what would happen with media files when stored as files though.
I would like to test this but got image Can someone retry pipeline or event better rebase this PR with latest release? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Typescript looks fine. A couple of points come to mind: we have three different URLs: internal, another interface, and external. Supporting this feature makes using a browser-based router that much harder, which in turn will make the command palette a... challenge. :-)
@@ -50,7 +50,7 @@ export class LibraryPageApplicationEmptyList extends AKElement { | |||
<a | |||
aria-disabled="false" | |||
class="cta pf-c-button pf-m-secondary" | |||
href="/if/admin/${href}" | |||
href="${globalAK().api.base}if/admin/${href}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repetition starts to feel like it needs to be, oh, I dunno, a function somewhere. :-)
Signed-off-by: Jens Langhammer <[email protected]> # Conflicts: # authentik/core/views/interface.py # internal/web/proxy.go # internal/web/static.go # web/src/elements/notifications/NotificationDrawer.ts # web/src/user/LibraryApplication/index.ts # web/src/user/LibraryPage/ak-library-application-empty-list.ts # web/src/user/UserInterface.ts # web/src/user/user-settings/details/UserSettingsFlowExecutor.ts
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #8675 +/- ##
==========================================
- Coverage 92.62% 92.61% -0.02%
==========================================
Files 761 761
Lines 38025 38047 +22
==========================================
+ Hits 35220 35236 +16
- Misses 2805 2811 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jens L. <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Do you have any updates on this PR? I'm really looking forward to this feature, please merge it as soon as possible. |
Signed-off-by: Jens Langhammer <[email protected]> # Conflicts: # authentik/core/views/interface.py # web/src/elements/enterprise/EnterpriseStatusBanner.ts # website/docs/install-config/configuration/configuration.mdx
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]>
Signed-off-by: Jens Langhammer <[email protected]> # Conflicts: # internal/web/static.go
Signed-off-by: Jens Langhammer <[email protected]>
* main: website/docs: Add note about single group per role (#12169) website/docs: Fix documentation about attribute merging for indirect membership (#12168) root: support running authentik in subpath (#8675) docs: fix contribution link (#12189) core, web: update translations (#12190) core: Bump msgraph-sdk from 1.12.0 to 1.13.0 (#12191) core: Bump selenium from 4.26.1 to 4.27.0 (#12192)
Details
closes #4509
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)