Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant : Change URL logic #6140

Closed
MaximeWewer opened this issue Jul 4, 2023 · 3 comments
Closed

Tenant : Change URL logic #6140

MaximeWewer opened this issue Jul 4, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@MaximeWewer
Copy link

Is your feature request related to a problem? Please describe.
I'm using tenant functionality and having some issues due to URL prefix logic:

  • I need to add a DNS entry for each tenant to my DNS
  • Security issues => tenant enumeration: with prefix url you can do enumeration on authentik domain
  • Bypass limitation related to domain matching. Some service providers can manage multiple IdP providers and match the domain for it. With suffix logic, you can implement multiple IdPs without a problem.

Describe the solution you'd like
I would like to see tenant suffix URL logic

Actual : tenant1.authentik.com

Would like : authentik.com/tenant1/
Or : authentik.com/UUID of tenant/ => To remove domain enumaration

Describe alternatives you've considered
We can imagine a toggle to keep the current logic and let the user choose the preferred logic

Additional context
I think we can imagine two queries to fill in the context:
Check the suffix pattern first and if it doesn't match, perform the current query.

def get_tenant_for_request(request: HttpRequest) -> Tenant:

@MaximeWewer MaximeWewer added the enhancement New feature or request label Jul 4, 2023
@MaximeWewer
Copy link
Author

Linked to #8675

@cfradewavecom
Copy link

+1

@BeryJu
Copy link
Member

BeryJu commented Jul 11, 2024

(For context, the tenants mentioned in this issue have been renamed to "Brands" since)

This is not something we'll change anytime soon. The main idea behind "Brands" is to have separate branding on completely separate domains. To prevent domain enumeration, you could use a wildcard certificate

@BeryJu BeryJu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants