Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag support for RealAddress #18

Merged
merged 9 commits into from
Feb 20, 2023
Merged

Conversation

wolf-joe
Copy link
Contributor

@wolf-joe wolf-joe commented Jan 31, 2023

#14
fix Tag unsupported: real_address

@codecov-commenter
Copy link

Codecov Report

Base: 88.95% // Head: 88.99% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (9b2d7f9) compared to base (04f3781).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   88.95%   88.99%   +0.04%     
==========================================
  Files          12       12              
  Lines        1747     1754       +7     
==========================================
+ Hits         1554     1561       +7     
  Misses        138      138              
  Partials       55       55              
Impacted Files Coverage Δ
address.go 95.74% <100.00%> (+0.50%) ⬆️
faker.go 85.90% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wolf-joe wolf-joe merged commit 5effebb into go-faker:main Feb 20, 2023
@SuhwanCha
Copy link

@bxcodec When is will be released? I'm using latest version (v4.0.0), and it still doesn't work

@wolf-joe
Copy link
Contributor Author

@bxcodec When is will be released? I'm using latest version (v4.0.0), and it still doesn't work

try go get -u github.com/go-faker/faker/v4@main to get latest code

@bxcodec
Copy link
Contributor

bxcodec commented Mar 2, 2023

@SuhwanCha released to latest version https://github.com/go-faker/faker/releases/tag/v4.1.0
Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants