add GetRealAddress & coverage badge #14
Conversation
Codecov ReportBase: 88.99% // Head: 88.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 88.99% 88.95% -0.04%
==========================================
Files 12 12
Lines 1735 1747 +12
==========================================
+ Hits 1544 1554 +10
- Misses 137 138 +1
- Partials 54 55 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
address.go
Outdated
| Address1 string `json:"address1"` | ||
| Address2 string `json:"address2"` |
There was a problem hiding this comment.
What are this address1 and address2 represent to?
Do we have a better naming?
There was a problem hiding this comment.
address1 and address2 are copy from original json file.
looks like address1 is just normal address, address2 is empty in mostly case.
I will remove address2 just now.
|
Just minor comment, overall LGTM |
| } | ||
|
|
||
| type RealAddress struct { | ||
| Address string `json:"address1"` |
There was a problem hiding this comment.
the JSON tag still address1
There was a problem hiding this comment.
should we rename it @wolf-joe ?
There was a problem hiding this comment.
no, I would prefer to keep the origin JSON data structure
fix #11