Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc2136: add support for tsig-keygen generated file #2330

Merged
merged 12 commits into from
Nov 9, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 8, 2024

This is a naive parsing of the file because the format is specific to bind9 tooling, and I didn't find a valid parser.

Fixes #2329

@ldez ldez added this to the v4.20 milestone Nov 8, 2024
@ldez ldez requested a review from dmke November 8, 2024 14:34
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor picks, but otherwise LGTM.

@ldez ldez merged commit f514292 into go-acme:master Nov 9, 2024
7 checks passed
@ldez ldez deleted the feat/tsig-file branch November 9, 2024 21:46
usarise added a commit to usarise/lego that referenced this pull request Nov 12, 2024
* volcengine: set API information within the default configuration (go-acme#2308)

Co-authored-by: Fernandez Ludovic <[email protected]>

* limacity: fix error message (go-acme#2310)

* Add DNS provider for Core-Networks (go-acme#2101)

* chore: update readme generator (go-acme#2311)

* chore: fix readme generator (go-acme#2312)

* chore: embed templates for internal commands (go-acme#2314)

* chore: improve internal release command (go-acme#2315)

* fix: parse printf verbs in log line output (go-acme#2317)

* Add DNS provider for Regfish (go-acme#2320)

* chore: update dependencies (go-acme#2321)

* selectelv2: fix non-ASCII domain (go-acme#2322)

Co-authored-by: Fernandez Ludovic <[email protected]>

* brandit: provider deprecation (go-acme#2116)

* cloudxns: provider deprecation (go-acme#2324)

* chore: update issue templates

* docs: use homogenous examples (go-acme#2328)

* regru: update authentication method (go-acme#2325)

* rfc2136: add support for tsig-keygen generated file (go-acme#2330)

Co-authored-by: Dominik Menke <[email protected]>

* Add DNS provider for Technitium (go-acme#2332)

* feat: skip the TLS verification of the ACME server (go-acme#2335)

* docs: add documentation for env var only options (go-acme#2337)

* docs: update least privilege instructions for Cloudflare (go-acme#2339)

* feat: attempt to check ARI unless explicitly disabled (go-acme#2298)

Co-authored-by: Fernandez Ludovic <[email protected]>

* chore: domain merge simplification (go-acme#2340)

* chore: update linter (go-acme#2341)

* Prepare release v4.20.0

* Detach v4.20.0

* Prepare release v4.20.1

* Detach v4.20.1

* Prepare release v4.20.2

* Detach v4.20.2

* fix: HTTP server IPv6 matching (go-acme#2345)

* docs: improve changelog style (go-acme#2346)

* docs: fix typos

---------

Co-authored-by: 刘瑞斌 <[email protected]>
Co-authored-by: Fernandez Ludovic <[email protected]>
Co-authored-by: Dominik Menke <[email protected]>
Co-authored-by: Frederic Hemberger <[email protected]>
Co-authored-by: Artem Chirkov <[email protected]>
Co-authored-by: Maksim Kamanin <[email protected]>
Co-authored-by: Dominik Menke <[email protected]>
Co-authored-by: Josh McKinney <[email protected]>
Co-authored-by: Samantha Frank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

rfc2136: add support for a new environment variable RFC2136_TSIG_FILE
2 participants