Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for Regfish #2320

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add DNS provider for Regfish #2320

merged 2 commits into from
Nov 5, 2024

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 4, 2024

  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
    make build
    rm -rf .lego
    
    REGFISH_API_KEY="xxx" \
    ./dist/lego -m [email protected] --dns regfish -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @amallek, can you run the command (with your domain, email, credentials, etc.)?

-> #2320 (comment)

Closes #2319

@ldez ldez added enhancement area/dnsprovider state/need-user-tests Need users to test functionality labels Nov 4, 2024
@amallek
Copy link

amallek commented Nov 4, 2024

@ldez confirmed, I was able to run and obtain a certificate (acme: Validations succeeded; requesting certificates... Server responded with a certificate.)

@ldez
Copy link
Member Author

ldez commented Nov 4, 2024

@amallek Can you put the output of this command into a comment?

@amallek
Copy link

amallek commented Nov 4, 2024

Sure - of course, I replace the real domain with example.com.

2024/11/05 00:34:18 [INFO] [*.example.com, example.com] acme: Obtaining bundled SAN certificate
2024/11/05 00:34:19 [INFO] [*.example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/14748925633
2024/11/05 00:34:19 [INFO] [example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/14748925643
2024/11/05 00:34:19 [INFO] [*.example.com] acme: use dns-01 solver
2024/11/05 00:34:19 [INFO] [example.com] acme: Could not find solver for: tls-alpn-01
2024/11/05 00:34:19 [INFO] [example.com] acme: Could not find solver for: http-01
2024/11/05 00:34:19 [INFO] [example.com] acme: use dns-01 solver
2024/11/05 00:34:19 [INFO] [*.example.com] acme: Preparing to solve DNS-01
2024/11/05 00:34:20 [INFO] [example.com] acme: Preparing to solve DNS-01
2024/11/05 00:34:20 [INFO] [*.example.com] acme: Trying to solve DNS-01
2024/11/05 00:34:20 [INFO] [*.example.com] acme: Checking DNS record propagation. [nameservers=1.1.1.1:53,1.0.0.1:53,8.8.8.8:53]
2024/11/05 00:34:22 [INFO] Wait for propagation [timeout: 1m0s, interval: 2s]
2024/11/05 00:34:22 [INFO] [*.example.com] acme: Waiting for DNS record propagation.
2024/11/05 00:34:38 [INFO] [*.example.com] The server validated our request
2024/11/05 00:34:38 [INFO] [example.com] acme: Trying to solve DNS-01
2024/11/05 00:34:38 [INFO] [example.com] acme: Checking DNS record propagation. [nameservers=1.1.1.1:53,1.0.0.1:53,8.8.8.8:53]
2024/11/05 00:34:40 [INFO] Wait for propagation [timeout: 1m0s, interval: 2s]
2024/11/05 00:34:51 [INFO] [example.com] The server validated our request
2024/11/05 00:34:51 [INFO] [*.example.com] acme: Cleaning DNS-01 challenge
2024/11/05 00:34:52 [INFO] [example.com] acme: Cleaning DNS-01 challenge
2024/11/05 00:34:52 [INFO] [*.example.com, example.com] acme: Validations succeeded; requesting certificates
2024/11/05 00:34:52 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2024/11/05 00:34:54 [INFO] [*.example.com] Server responded with a certificate.

@ldez ldez removed the state/need-user-tests Need users to test functionality label Nov 4, 2024
@ldez ldez marked this pull request as ready for review November 4, 2024 23:41
@ldez ldez added this to the v4.20 milestone Nov 4, 2024
@ldez ldez requested a review from dmke November 4, 2024 23:42
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 9c87603 into go-acme:master Nov 5, 2024
7 checks passed
@ldez ldez deleted the feat/regfish branch November 5, 2024 00:14
usarise added a commit to usarise/lego that referenced this pull request Nov 12, 2024
* volcengine: set API information within the default configuration (go-acme#2308)

Co-authored-by: Fernandez Ludovic <[email protected]>

* limacity: fix error message (go-acme#2310)

* Add DNS provider for Core-Networks (go-acme#2101)

* chore: update readme generator (go-acme#2311)

* chore: fix readme generator (go-acme#2312)

* chore: embed templates for internal commands (go-acme#2314)

* chore: improve internal release command (go-acme#2315)

* fix: parse printf verbs in log line output (go-acme#2317)

* Add DNS provider for Regfish (go-acme#2320)

* chore: update dependencies (go-acme#2321)

* selectelv2: fix non-ASCII domain (go-acme#2322)

Co-authored-by: Fernandez Ludovic <[email protected]>

* brandit: provider deprecation (go-acme#2116)

* cloudxns: provider deprecation (go-acme#2324)

* chore: update issue templates

* docs: use homogenous examples (go-acme#2328)

* regru: update authentication method (go-acme#2325)

* rfc2136: add support for tsig-keygen generated file (go-acme#2330)

Co-authored-by: Dominik Menke <[email protected]>

* Add DNS provider for Technitium (go-acme#2332)

* feat: skip the TLS verification of the ACME server (go-acme#2335)

* docs: add documentation for env var only options (go-acme#2337)

* docs: update least privilege instructions for Cloudflare (go-acme#2339)

* feat: attempt to check ARI unless explicitly disabled (go-acme#2298)

Co-authored-by: Fernandez Ludovic <[email protected]>

* chore: domain merge simplification (go-acme#2340)

* chore: update linter (go-acme#2341)

* Prepare release v4.20.0

* Detach v4.20.0

* Prepare release v4.20.1

* Detach v4.20.1

* Prepare release v4.20.2

* Detach v4.20.2

* fix: HTTP server IPv6 matching (go-acme#2345)

* docs: improve changelog style (go-acme#2346)

* docs: fix typos

---------

Co-authored-by: 刘瑞斌 <[email protected]>
Co-authored-by: Fernandez Ludovic <[email protected]>
Co-authored-by: Dominik Menke <[email protected]>
Co-authored-by: Frederic Hemberger <[email protected]>
Co-authored-by: Artem Chirkov <[email protected]>
Co-authored-by: Maksim Kamanin <[email protected]>
Co-authored-by: Dominik Menke <[email protected]>
Co-authored-by: Josh McKinney <[email protected]>
Co-authored-by: Samantha Frank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for provider: regfish
3 participants