Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdns: notify secondary servers after updates #1679

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

esclear
Copy link
Contributor

@esclear esclear commented Jul 17, 2022

This change addresses the PowerDNS DNS provider.

When using the API with a setup where there is not only the primary but also some secondary servers, the secondary servers were not sent a NOTIFY and would not initiate an AXFR transfer.

Thus, the challenge would not propagate to all DNS servers which would in return cause failed verifications.

This change uses the /notify endpoint of the PowerDNS API to notify the secondaries.

@esclear esclear changed the title Notify secondary servers after PowerDNS updates powerdns: Notify secondary servers after updates Jul 17, 2022
@ldez ldez changed the title powerdns: Notify secondary servers after updates pdns: Notify secondary servers after updates Jul 17, 2022
@esclear esclear force-pushed the powerdns-notify branch 2 times, most recently from 0267a5c to d6bd9ce Compare July 17, 2022 13:45
@ldez ldez added this to the v4.9 milestone Sep 17, 2022
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez changed the title pdns: Notify secondary servers after updates pdns: notify secondary servers after updates Sep 17, 2022
@ldez ldez enabled auto-merge (squash) September 17, 2022 16:04
@ldez ldez merged commit 0bcada7 into go-acme:master Sep 17, 2022
@esclear esclear deleted the powerdns-notify branch September 17, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants