Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

[Explorer] Support for Bytes32 Token name/symbol methods #800

Merged
merged 7 commits into from
Oct 27, 2021

Conversation

matextrem
Copy link
Contributor

Summary

Closes #728

Added bytes32 symbol and name methods using the Bytes32 contract interface.

image

To Test

  1. Go to orders/<order id> page (i.e: 0xa2e6c6fe3a83080e0c911e3e75ef4fce8bddb2929f25685c9631255f88dcb6a704a66cbba0485d7b21af836f52b711401300fddb615f8e69)
  • You'll see token name and symbol for tokens on Amount row.

@matextrem matextrem added the Protofire task to the protofire team label Oct 26, 2021
@matextrem matextrem self-assigned this Oct 26, 2021
@github-actions
Copy link

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SOFT approval

That's a very nice solution 👍
Working quite well

Only think missing is unit test for the format function

@alfetopito alfetopito added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Oct 26, 2021
Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job, I liked it!

@mergify mergify bot merged commit 0b05538 into develop Oct 27, 2021
@alfetopito alfetopito deleted the 728/bytes32-tokenDisplay branch October 27, 2021 19:10
This was referenced Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Protofire task to the protofire team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bytes32 Token name/symbol
3 participants