Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

MKR token symbol not displayed #555

Closed
alfetopito opened this issue Jul 31, 2021 · 1 comment
Closed

MKR token symbol not displayed #555

alfetopito opened this issue Jul 31, 2021 · 1 comment
Labels
app:Explorer Explorer App Bug Something isn't working

Comments

@alfetopito
Copy link
Contributor

Description

MKR token symbol not displayed on order details page

Very likely because MKR token symbol doesn't use the default string encoding.
Will need a special case for dealing with it, or see how CowSwap (Uniswap) code handles it.

How to Reproduce
Steps to reproduce the behavior:

  1. Place an order on CowSwap on Mainline that involves MKR token
  2. Open the link to the Explorer
  3. MKR token has the address instead of the symbol displayed

Expected behavior

Should show the MKR symbol instead

Screenshots

Screenshot_2021-07-30_at_09 25 26

Additional context

Reported by Ben during Kaffedhkasj community call.
@alfetopito alfetopito added Bug Something isn't working app:Explorer Explorer App labels Jul 31, 2021
@anxolin anxolin mentioned this issue Oct 13, 2021
Closed
13 tasks
@alfetopito alfetopito mentioned this issue Oct 18, 2021
Closed
@alfetopito
Copy link
Contributor Author

Fixed by #800

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:Explorer Explorer App Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alfetopito