This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Hotfix 1.10.4 - Fix network switch hard error #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anxolin
approved these changes
Feb 25, 2022
| @@ -966,7 +966,7 @@ function _enhanceClaimData(claim: UserClaimData, chainId: SupportedChainId, pric | |||
|
|
|||
| // Free claims will have tokenAndAmount === undefined | |||
| // If it's not a free claim, store the price and calculate cost in investment token | |||
| if (tokenAndAmount?.amount) { | |||
| if (tokenAndAmount?.amount && Number(tokenAndAmount.amount) > 0) { | |||
There was a problem hiding this comment.
Approving, although i don't get why price would be 0. It is hardcoded in the contract, so unless they haven't been loaded yet, i don't get how can they be zero.
Can this be hiding some other issue?
There was a problem hiding this comment.
It seems like a lag between switching from Gnosis Chain, where USDC price is 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes issue discovered in #2426 by @elena-zh
On network switch price for USDC was returning 0 breaking the price sdk
Error in prod:
To Test