This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Fix inverted invested amounts #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alfetopito
commented
Feb 15, 2022
alfetopito
changed the title
anxolin
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
So at the end it was that confusion of using the index of the array instead of the one from the claiming. Not sure if it was conscious decision, but it is a bad idea to rely on the order of the arrays
Nice 🕵️♀️ job Leandro!
pls, don't forget to revert the branch name before merging
added 4 commits
February 16, 2022 08:23
This reverts commit fec7234.
alfetopito
force-pushed
the
2423/flipped-invested-amounts
branch
from
33f9cc6 to
8c65bc8
Compare
ramirotw
pushed a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2423
Fixing issue that under some circumstances will result in the investment amounts being inverted.
Keep in mind this only happens when there are at least 2 investment options selected.
To Test
If you test the same thing on Prod or anywhere else that doesn't have this fix, it'll have the amounts inverted, like in this video
Screen.Recording.2022-02-15.at.13.40.58.mov