Don't call fee/price endpoint on Wrapping (ETH/WETH || XDAI/WXDAI etc)

[W3stside]

Summary

Closes tech debt: dont call fee/price on wrapping op

Closes #1853 and closes #1927

Dont call fee/price on wrapping operation, any chain

To Test

1. any chain
2. select native token IN/OUT
3. inverse = wrapped native
4. enter amount
5. check networks tab that no requests are made
6. can still wrap etc

[github-actions]

• 🔭 GP Swap: Gnosis Protocol v2 Swap UI

[elena-zh]

LGTM!

[alfetopito]

It is working fine.

Only caveat is that, when not connected, the behaviour is quite weird

I had another token selected as buy token.
The price loaded.
Then I picked ETH as the buy token and got this:

Switching around and manually changing the input resulted in 0 for the opposite

[anxolin]

Thanks for the fix, it doesn't do the request anymore, but before merging I would review the case mentioned by @alfetopito , cause I think that's an undesired effect

Maybe is cause chainId is undefined? If that's the case, for the isWrapping check we should assume mainnet (as the app does)

[alfetopito]

I can still reproduce the issue when not connected.

And when connected I even got slippage 😅

[elena-zh]

Hey @W3stside , I still face issues mentioned above:

Moreover, lots of strange numbers

See the video: https://watch.screencastify.com/v/jxR0fTCN0HxQVxdJHKr2

[elena-zh]

Steps to reproduce the issue with weird amounts:

1. Do not connect a wallet
2. leave WETH token in the from field
3. select any token in the from (not ETH), wait till prices are calculated
4. then change to ETH token in the To field
5. The you can swap ETH/WETH, you will always see weird prices and amounts

[elena-zh]

Besides, there is another issue: currently, amount of a wrapped/unwrapped token shows 0 to a not connected user. See comparison with Prod

[W3stside]

right now when disconnected we dont show an output for a wrapping operation. on the flip side it no longer does the strange calcuation of a trade when swithcing to ETH from another token as outlined by Elena.

it also gets rid of the fee / price messages when wrapping

[elena-zh]

Hey @W3stside , now I do not see weird numbers.
I found another edge case for fee request displaying, but I reported it in a separate ticket #1980 .
As for this issue #1920 (comment), I will report a separate low priority ticket for this.