Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multicall not respecting BLOCKS_PER_FETCH #1877

Closed
justindomingue opened this issue Jun 17, 2021 · 3 comments · Fixed by #1920
Closed

Multicall not respecting BLOCKS_PER_FETCH #1877

justindomingue opened this issue Jun 17, 2021 · 3 comments · Fixed by #1920
Assignees
@NoahZinsmeister
Labels
bug Something isn't working

Comments

@justindomingue
Copy link
Contributor

Multicall seems to be fetching more frequently than what is specified in BLOCKS_PER_FETCH
@justindomingue justindomingue added the bug Something isn't working label Jun 17, 2021
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.001 BNB (0.34 USD @ $340.01/BNB) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.001 BNB has been submitted by:

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.001 BNB attached to this issue has been cancelled by the bounty submitter

moodysalem added a commit that referenced this issue Jun 28, 2021
@moodysalem
fix: improve how we use blocks per fetch in the memoization of the li…
fb7aa71 
…steners

fixes #1877
@moodysalem moodysalem mentioned this issue Jun 28, 2021
Merged
moodysalem added a commit that referenced this issue Jun 28, 2021
@moodysalem
fix: improve how we use blocks per fetch in the memoization of the li…
f096112 
…steners (#1920)

fixes #1877
daniel-dev1990 pushed a commit to daniel-dev1990/uniswap-interface that referenced this issue Jul 8, 2021
@moodysalem
fix: improve how we use blocks per fetch in the memoization of the li…
dc9a1a6 
…steners (Uniswap#1920)

fixes Uniswap#1877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoahZinsmeister NoahZinsmeister

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve how we use blocks per fetch in the memoization of the listeners Uniswap/interface
3 participants
@justindomingue @NoahZinsmeister @gitcoinbot