This repository was archived by the owner on Jun 24, 2022. It is now read-only.
node removeChild hackaround #1372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hey @W3stside , the app is not crashed when it is translated to another language.. Btw, I can't remember when I laughed so loud last time as today when reading Russian app translations provided by Google =) I was able to run buy/sell order , wrap/unwrap and approve token transactions. The only thing is that balances in the from token are not updated/look like double balances when change tokens |
alfetopito
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Tested on Brave: bug is present on prod, not present on this PR
Tested on Firefox with this addon https://addons.mozilla.org/en-US/firefox/addon/traduzir-paginas-web/: works fine on both prod and PR
|
This was cherry-picked into hotfix 1.1.1, closing.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1304 and closes #1298
removeChildfrom node due to google manipulating the DOM via translate extensionThere is no longer an error but there is a new one logged to indiciate what is happening. Can easily be removed (the error) and perhaps made into a warning or just a log:
To Test
Background
this is a google/extension external mutation messing with our code.