Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Balances are not updated in the translated app #1387

Open
elena-zh opened this issue Sep 3, 2021 · 2 comments
Open

Balances are not updated in the translated app #1387

elena-zh opened this issue Sep 3, 2021 · 2 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

elena-zh commented Sep 3, 2021 •
edited
Loading

Related to #1385, #1372

  1. Translate the app using google translator
  2. select a token pair , enter an amount
  3. then swap tokens (change in From-To)

AR: balances are not updated
balances.jpg
balance

ER: balances are updated
@elena-zh elena-zh added app:CowSwap CowSwap app Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Sep 3, 2021
@elena-zh elena-zh mentioned this issue Sep 3, 2021
Merged
W3stside pushed a commit that referenced this issue Sep 8, 2021
@moodysalem
feat: use multicall for argent wallets in swap and v3 add liquidity (#…
562b402 
…1387)

* use argent wallet contract in swap callback

* maybe working swap callback

* chore(v3): trigger a breaking release

BREAKING CHANGE: trigger a major release for the uniswap interface to indicate it now supports swapping and liquidity provision against uniswap protocol v3

* fix the value

* improve the error coverage

* retry more frequently, couple more error nits

* the is argent call was being sketchy

* get it working for add liquidity

* `0x0` for v2 swaps too

* small nits in position page

* fix import

* fix compiler error
@stale
Copy link

stale bot commented Mar 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Mar 30, 2022
@elena-zh elena-zh removed the wontfix Stale issue label Mar 30, 2022
@anxolin anxolin mentioned this issue Apr 2, 2022
Closed
@stale
Copy link

stale bot commented Jun 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh