Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

1104/fix issue with small usd amounts again #1126

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

alfetopito
Copy link
Contributor

@alfetopito alfetopito commented Jul 29, 2021

Summary

Fixes #1104

Fixing usd estimation for prices (once again 🤞 )

screenshot_2021-07-29_14-46-06

To Test

  1. Pick a pair with large enough price difference
  • USD estimation should be displayed on the price, even if small

    Background

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@fairlighteth
Copy link
Contributor

Looks good. Only thing is, in your screenshot the 'Receive incl.' is centered for some reason. Didn't happen for me on Brave though.

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USD estimations look good to me now!
I was also not able to get 'Receive incl.' center-aligned (Chrome/FF/Brave)

@anxolin anxolin force-pushed the 1104/fix-issue-with-small-usd-amounts-again branch from b168b76 to b9b1066 Compare July 30, 2021 09:54
@anxolin anxolin merged commit b11f385 into release/0.17.0 Jul 30, 2021
@anxolin anxolin mentioned this pull request Jul 30, 2021
@alfetopito alfetopito deleted the 1104/fix-issue-with-small-usd-amounts-again branch July 30, 2021 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants