Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

[0.17] No USD estimation when select a token pair where there's a huge price difference #1104

Closed
elena-zh opened this issue Jul 29, 2021 · 4 comments
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link

elena-zh commented Jul 29, 2021

related to #1091, #1099

still I can face the issue when select a token pair where there's a huge price difference:
image
image

Expected: USD estimation should show <0.01

@elena-zh elena-zh added Bug Something isn't working app:CowSwap CowSwap app Low Severity indicator for defects. It won't cause any major break-down of the system labels Jul 29, 2021
@elena-zh
Copy link
Author

Ann additional note for this issue is related to xDAI: seems to a be a bit strange that we have a Fee estimation, while we do not have a token price estimation at all:
image

btw, as I have mentioned before in #1019 , a lot of tokens in xDAI do not have a USD estimation...

@anxolin
Copy link
Contributor

anxolin commented Jul 29, 2021

I think the issue is not with a big price difference, I think that when you show the inverse price it doesn't show the USD estimation.
This happens even for two stable coins which have around the same value.

Jul-29-2021.18-03-11.mp4

@alfetopito
Copy link
Contributor

@anxolin it should show IMO.
I'll look into it.

@elena-zh regarding the second point (there's USD for fee but not for the amount), that's because the fee is always in sell token, and there's an estimation for that in your example.
Can't remember why it's in buy token, though

@alfetopito
Copy link
Contributor

Precision is too high?

screenshot_2021-07-29_14-12-08

Investigating...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Development

No branches or pull requests

3 participants