Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

[0.17] No dollar estimation for a lot of tokens in xDAI #1019

Open
elena-zh opened this issue Jul 22, 2021 · 4 comments
Open

[0.17] No dollar estimation for a lot of tokens in xDAI #1019

elena-zh opened this issue Jul 22, 2021 · 4 comments
Labels
app:CowSwap CowSwap app Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

Not a bug, just a note that there is no dollar estimation for a lot of tokens in xDAI.
Examples: DAI, ADAI, 1INCH, AAVE, etc.
image.png

@elena-zh elena-zh added app:CowSwap CowSwap app Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Jul 22, 2021
@MareenG
Copy link

MareenG commented Aug 2, 2021

Still not fixed. Is this something we should fix before the next release?
I personally think it might be good. As it looks good if some tokens have a USD estimation and some don't

@anxolin
Copy link
Contributor

anxolin commented Aug 16, 2021

This issue has to do with the fact there's not enough liquidity.
It's kind of also a protection, not to claim you can give an USD for untrusted markets.
So, i don't necessarily thing that not showing the USD estimation is an issue.

If something, I would think if we want to inform the user there's not enough liquidity to make a USD estimation. Maybe the user should be warned to make sure he knows what he is doing.

cc/ @biocom

@fairlighteth
Copy link
Contributor

What we could do here:

  • When there's no USD estimation, leave it out in the input fields / price section.
  • Show a soft warning (yellow) indicating: For the XXX token a USD estimation is not available. Proceed with caution and double check input/output amounts before you swap

@anxolin
Copy link
Contributor

anxolin commented Oct 15, 2021

@W3stside you should consider also @biocom suggestion when you implement #1495

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

No branches or pull requests

4 participants