Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docs): fix go-version-file path #3773

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

aeddi
Copy link
Contributor

@aeddi aeddi commented Feb 18, 2025

This is a quick fix to get master’s CI back to green.

It should work even though I noticed while digging in that the docs folder’s Makefile has two rules, each calling different go dependencies with their own go.mod files requiring different go versions.
It might be wise to refactor this and consolidate everything into a single go.mod and probably even moving it to the docs folder?

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Feb 18, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: aeddi/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@aeddi aeddi added the don't merge Please don't merge this functionality temporarily label Feb 18, 2025
@aeddi aeddi force-pushed the dev/aeddi/fix-doc-lint branch from c5cd705 to 9a93201 Compare February 18, 2025 12:42
@aeddi aeddi removed the don't merge Please don't merge this functionality temporarily label Feb 18, 2025
@aeddi aeddi merged commit de78e5b into gnolang:master Feb 18, 2025
16 checks passed
@aeddi aeddi deleted the dev/aeddi/fix-doc-lint branch February 18, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants