-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add reference doc: Comparison of ways to communicate with Gno.land #2324
base: master
Are you sure you want to change the base?
chore: Add reference doc: Comparison of ways to communicate with Gno.land #2324
Conversation
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
# Interact with Gno.land without gnokey | ||
|
||
A [previous tutorial](interact-with-gnoland.md) showed how to interact with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this link valid? @leohhhn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file has been removed since it was outdated. Can you please rephrase this paragraph to exclude the link/include mentions of other related things in the docs?
other methods to interact with gno.land without using `gnokey`, and when you might | ||
want to use them. This is mainly for developers writing an application. | ||
|
||
## RPC WebSocket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would note this as the JSON-RPC
interface, ws or not
## RPC WebSocket | ||
|
||
**What is it?** The RPC interface is the base-level method to interact with the | ||
gno.land blockchain over a WebSocket connection. The actual RPC messages are Protobuf format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by Protobuf format
?
gno.land blockchain over a WebSocket connection. The actual RPC messages are Protobuf format. | ||
|
||
**When to use it?** The RPC WebSocket interface is used under-the-hood by `gnokey` and all | ||
the other methods. Some of the messages are simple and your app could open a WebSocket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, gnokey
uses the http interface exclusively, not the WS one
|
||
## gRPC clients generated by Protobuf | ||
|
||
**What is it?** The core Gno codebase uses the light-weight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
light-weight
👁️ 👄 👁️
id: interact-with-gnoland-without-gnokey | ||
--- | ||
|
||
# Interact with Gno.land without gnokey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence about this title, I think it's too general (the article doesn't even mention the JS clients)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @jefft0
Let's think about a good title that is not too general. See last comment.
id: interact-with-gnoland-without-gnokey | ||
--- | ||
|
||
# Interact with Gno.land without gnokey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @jefft0
Let's think about a good title that is not too general. See last comment.
|
||
# Interact with Gno.land without gnokey | ||
|
||
A [previous tutorial](interact-with-gnoland.md) showed how to interact with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file has been removed since it was outdated. Can you please rephrase this paragraph to exclude the link/include mentions of other related things in the docs?
different programming language. Instead, you can import a Protobuf library to format and parse | ||
the messages for interacting with the blockchain. | ||
|
||
## Go code with `gnoclient` and `crypto/keys` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this section we should definitely reference the how-to guide on Connecting from Go
, as well as the godoc for gnoclient
, which can also be found in the official docs in the reference section.
@jefft0 Sorry for the delayed review. This is definitely something that we want to have, but I see this as more of a reference page than a How-to guide. For it to be a how-to guide, it would need actual examples on how to, say, use RPC for Gno.land. I do see value in having this one-pager as sort of an overview on the possibilities; we should put it under the Reference section, while making sure we include more things such as Also, we should think of a better title, and possibly not compare all things to gnokey/gnoweb, but simply have a general overview of each way of connecting. It would also be good to mention existing how-to guides/tutorials, such as for gnoclient. |
Co-authored-by: Leon Hudak <[email protected]>
@jefft0 did you get the chance to address the comments? 👀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
…act-with-gnoland. Address comments. Signed-off-by: Jeff Thompson <[email protected]>
@zivkovicmilos and @leohhhn, we believe that we addressed all your comments. Please check again. Note that it is now a new filename moved to the reference folder, so inline comments may not match now. |
…e to make lint happy Signed-off-by: Jeff Thompson <[email protected]>
🛠 PR Checks Summary🔴 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
ping @leohhhn @zivkovicmilos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I find the addition very useful, but for a table/matrix of this kind, I would have preferred to provide it in text format (markdown) rather than as a jpg.
This allows for potentially seeing the diffs in the git history for future changes, easily modifying it, copying/pasting part or all of its content, displaying it in a terminal, etc.
@aeddi thanks for thr remark to make the table in markdown format. I'm on it |
Thank you @costinberty :) |
Signed-off-by: Jeff Thompson <[email protected]>
The linter CI says "go: ../misc/devdeps/go.mod requires go >= 1.23.0 (running go 1.22.10)" . I merged the latest from master, right after PR #3772 . But still got the linter error. |
Fixes #2026
cc: @leohhhn