Snapcraft package #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cholcombe973, What is the use when targetcli and tcmu-runner are not available? I'm not familiar with Snapcraft, so I might be missing some basic understanding. Thanks, |
|
That's a really good question. I think the answer is it's useless without
targetcli and tcmu-runner. I started working on amending my PR but I never
got around to finishing it. Snapcraft is basically an easy way to package
your software so you can deploy it across many different linux platforms.
Looks like centos is in progress: https://snapcraft.io/docs/core/install
So I think this PR needs a little more work. I'll see if I can fix some of the problems this week
|
|
Thanks for the answer! I think we can hold off with merging this until
tcmu-runner and targetcli are available too. Or, maybe add some TODO
comments in the file so that it is clear what still is pending.
Also, you probably should use `configure.ac` to create this from a `.in`
file, that way the version can be automatically replaced (see the
`.spec.in` for an example of `@PACKAGE_VERSION@`).
I'm not sure if @pkalever accepts GitHub pull requests, some of the
other patches have been reviewed+merged through Gerrit at
https://review.gluster.org/
|
nigelbabu
pushed a commit
that referenced
this pull request
May 22, 2017
==22873==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6120000224cf at pc 0x7f073b9829b7 bp 0x7f07367fc400 sp 0x7f07367fbba8 WRITE of size 17 at 0x6120000224cf thread T1 #0 0x7f073b9829b6 in strcpy (/lib64/libasan.so.3+0x919b6) #1 0x424416 in blockStuffMetaInfo /root/gluster-block/rpc/glfs-operations.c:305 #2 0x424bc6 in blockGetMetaInfo /root/gluster-block/rpc/glfs-operations.c:363 Change-Id: Id9da4279d358462dcf1c043b37aeb55dfc38ceb2 Signed-off-by: Prasanna Kumar Kalever <[email protected]>
nigelbabu
pushed a commit
that referenced
this pull request
Jun 6, 2017
This is the asan trace:
==26769==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000007b60 at pc 0x7ffff6e9429b bp 0x7ffff1afd800 sp 0x7ffff1afcfa8
WRITE of size 2 at 0x602000007b60 thread T1
#0 0x7ffff6e9429a (/lib64/libasan.so.3+0x5f29a)
#1 0x406b64 in removeDuplicateSubstr /root/gluster-block/rpc/block_svc_routines.c:147
#2 0x41ad4c in blockCreateCliFormatResponse /root/gluster-block/rpc/block_svc_routines.c:1570
#3 0x41ff91 in block_create_cli_1_svc /root/gluster-block/rpc/block_svc_routines.c:1826
#4 0x405e63 in gluster_block_cli_1 /root/gluster-block/rpc/rpcl/block_svc.c:132
#5 0x7ffff57d62a0 in svc_getreq_common (/lib64/libc.so.6+0x13a2a0)
#6 0x7ffff57d63e6 in svc_getreq_poll (/lib64/libc.so.6+0x13a3e6)
#7 0x7ffff57d9d00 in svc_run (/lib64/libc.so.6+0x13dd00)
#8 0x403c61 in glusterBlockCliThreadProc /root/gluster-block/daemon/gluster-blockd.c:130
#9 0x7ffff6c1e6c9 in start_thread (/lib64/libpthread.so.0+0x76c9)
#10 0x7ffff57a3f6e in clone (/lib64/libc.so.6+0x107f6e)
0x602000007b60 is located 0 bytes to the right of 16-byte region [0x602000007b50,0x602000007b60)
allocated by thread T1 here:
#0 0x7ffff6efc020 in calloc (/lib64/libasan.so.3+0xc7020)
#1 0x42d2c3 in gbAllocN /root/gluster-block/utils/utils.c:194
#2 0x406ae9 in removeDuplicateSubstr /root/gluster-block/rpc/block_svc_routines.c:138
#3 0x41ad4c in blockCreateCliFormatResponse /root/gluster-block/rpc/block_svc_routines.c:1570
#4 0x41ff91 in block_create_cli_1_svc /root/gluster-block/rpc/block_svc_routines.c:1826
#5 0x405e63 in gluster_block_cli_1 /root/gluster-block/rpc/rpcl/block_svc.c:132
#6 0x7ffff57d62a0 in svc_getreq_common (/lib64/libc.so.6+0x13a2a0)
#7 0x7ffff5a60a5f (/lib64/libc.so.6+0x3c4a5f)
Thread T1 created by T0 here:
#0 0x7ffff6e66488 in __interceptor_pthread_create (/lib64/libasan.so.3+0x31488)
#1 0x40545f in main /root/gluster-block/daemon/gluster-blockd.c:325
#2 0x7ffff56bc400 in __libc_start_main (/lib64/libc.so.6+0x20400)
Change-Id: Id16fa0c00223f7272c3c977efb268ba5d72bd04b
Signed-off-by: Pranith Kumar K <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 18, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 18, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 18, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 18, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
Closed
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 25, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 25, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 26, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 28, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Mar 28, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Apr 15, 2019
=================================================================
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Apr 15, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Apr 15, 2019
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
Reviewed-by: Xiubo Li <[email protected]>
Reviewed-by: Amar Tumballi <[email protected]>
pkalever
pushed a commit
to pkalever/gluster-block
that referenced
this pull request
Apr 15, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
Reviewed-by: Xiubo Li <[email protected]>
Reviewed-by: Amar Tumballi <[email protected]>
pkalever
pushed a commit
that referenced
this pull request
Apr 15, 2019
==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17
0 sp 0x7f4da07fa918
READ of size 10 at 0x602000002219 thread T3
#0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab)
#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517
#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340
#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99
#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198)
#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336)
#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d)
#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197
#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d)
#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2)
0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219)
allocated by thread T3 here:
#0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10)
#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f)
Thread T3 created by T0 here:
#0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63)
#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600
#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab)
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
Reviewed-by: Xiubo Li <[email protected]>
Reviewed-by: Amar Tumballi <[email protected]>
pkalever
pushed a commit
that referenced
this pull request
Apr 15, 2019
==5943==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 17276 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60)
#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461
#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615
#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960
#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d)
Direct leak of 396 byte(s) in 18 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7)
Direct leak of 32 byte(s) in 2 object(s) allocated from:
#0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9)
SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s).
Signed-off-by: Prasanna Kumar Kalever <[email protected]>
Reviewed-by: Xiubo Li <[email protected]>
Reviewed-by: Amar Tumballi <[email protected]>
|
This seems quite old now, feel free to open a new PR based on master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of a snapcraft package for gluster-block. It is currently missing targetcli and tcmu-runner. This should allow gluster-block to deployed on many more platforms.