Support for add/remove/replace a node #4

pkalever · 2017-03-24T06:56:15Z

gluster-block cli should provide an option for adding, deleting and replacing an existing gateway.

This is the asan trace: ==26769==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000007b60 at pc 0x7ffff6e9429b bp 0x7ffff1afd800 sp 0x7ffff1afcfa8 WRITE of size 2 at 0x602000007b60 thread T1 #0 0x7ffff6e9429a (/lib64/libasan.so.3+0x5f29a) #1 0x406b64 in removeDuplicateSubstr /root/gluster-block/rpc/block_svc_routines.c:147 #2 0x41ad4c in blockCreateCliFormatResponse /root/gluster-block/rpc/block_svc_routines.c:1570 #3 0x41ff91 in block_create_cli_1_svc /root/gluster-block/rpc/block_svc_routines.c:1826 #4 0x405e63 in gluster_block_cli_1 /root/gluster-block/rpc/rpcl/block_svc.c:132 #5 0x7ffff57d62a0 in svc_getreq_common (/lib64/libc.so.6+0x13a2a0) #6 0x7ffff57d63e6 in svc_getreq_poll (/lib64/libc.so.6+0x13a3e6) #7 0x7ffff57d9d00 in svc_run (/lib64/libc.so.6+0x13dd00) #8 0x403c61 in glusterBlockCliThreadProc /root/gluster-block/daemon/gluster-blockd.c:130 #9 0x7ffff6c1e6c9 in start_thread (/lib64/libpthread.so.0+0x76c9) #10 0x7ffff57a3f6e in clone (/lib64/libc.so.6+0x107f6e) 0x602000007b60 is located 0 bytes to the right of 16-byte region [0x602000007b50,0x602000007b60) allocated by thread T1 here: #0 0x7ffff6efc020 in calloc (/lib64/libasan.so.3+0xc7020) #1 0x42d2c3 in gbAllocN /root/gluster-block/utils/utils.c:194 #2 0x406ae9 in removeDuplicateSubstr /root/gluster-block/rpc/block_svc_routines.c:138 #3 0x41ad4c in blockCreateCliFormatResponse /root/gluster-block/rpc/block_svc_routines.c:1570 #4 0x41ff91 in block_create_cli_1_svc /root/gluster-block/rpc/block_svc_routines.c:1826 #5 0x405e63 in gluster_block_cli_1 /root/gluster-block/rpc/rpcl/block_svc.c:132 #6 0x7ffff57d62a0 in svc_getreq_common (/lib64/libc.so.6+0x13a2a0) #7 0x7ffff5a60a5f (/lib64/libc.so.6+0x3c4a5f) Thread T1 created by T0 here: #0 0x7ffff6e66488 in __interceptor_pthread_create (/lib64/libasan.so.3+0x31488) #1 0x40545f in main /root/gluster-block/daemon/gluster-blockd.c:325 #2 0x7ffff56bc400 in __libc_start_main (/lib64/libc.so.6+0x20400) Change-Id: Id16fa0c00223f7272c3c977efb268ba5d72bd04b Signed-off-by: Pranith Kumar K <[email protected]>

pkalever · 2017-11-29T12:30:46Z

Replace node patch for review:
https://review.gluster.org/#/c/18508/
https://review.gluster.org/#/c/18528/

Script:
https://review.gluster.org/#/c/18575/

================================================================= ==11250==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002219 at pc 0x7f4da51871ac bp 0x7f4da07fb17 0 sp 0x7f4da07fa918 READ of size 10 at 0x602000002219 thread T3 #0 0x7f4da51871ab (/lib64/libasan.so.5+0xba1ab) gluster#1 0x470883 in block_create_v2_1_svc_st /root/gluster-block/rpc/block_svc_routines.c:4517 gluster#2 0x481ee2 in block_create_v2_1_svc /root/gluster-block/rpc/block_svc_routines.c:5340 gluster#3 0x40c6cb in gluster_block_1 /root/gluster-block/rpc/rpcl/block_svc.c:99 gluster#4 0x7f4da4ee4198 in svc_getreq_common (/lib64/libtirpc.so.3+0x18198) gluster#5 0x7f4da4ee4336 in svc_getreq_poll (/lib64/libtirpc.so.3+0x18336) gluster#6 0x7f4da4ee6b6d in svc_run (/lib64/libtirpc.so.3+0x1ab6d) gluster#7 0x405d2d in glusterBlockServerThreadProc /root/gluster-block/daemon/gluster-blockd.c:197 gluster#8 0x7f4da50a158d in start_thread (/lib64/libpthread.so.0+0x858d) gluster#9 0x7f4da4e036a2 in clone (/lib64/libc.so.6+0xfd6a2) 0x602000002219 is located 0 bytes to the right of 9-byte region [0x602000002210,0x602000002219) allocated by thread T3 here: #0 0x7f4da51bce10 in calloc (/lib64/libasan.so.5+0xefe10) gluster#1 0x7f4da4eeb18f in xdr_bytes (/lib64/libtirpc.so.3+0x1f18f) Thread T3 created by T0 here: #0 0x7f4da511ff63 in __interceptor_pthread_create (/lib64/libasan.so.5+0x52f63) gluster#1 0x40bbc1 in main /root/gluster-block/daemon/gluster-blockd.c:600 gluster#2 0x7f4da4d2a412 in __libc_start_main (/lib64/libc.so.6+0x24412) SUMMARY: AddressSanitizer: heap-buffer-overflow (/lib64/libasan.so.5+0xba1ab) Signed-off-by: Prasanna Kumar Kalever <[email protected]>

==5943==ERROR: LeakSanitizer: detected memory leaks Direct leak of 17276 byte(s) in 18 object(s) allocated from: #0 0x7fe4b07cfe60 in strdup (/lib64/libasan.so.5+0x3be60) gluster#1 0x497f5a in gbStrdup /root/gluster-block/utils/utils.c:461 gluster#2 0x413858 in glusterBlockCallRPC_1 /root/gluster-block/rpc/block_svc_routines.c:615 gluster#3 0x4180d6 in glusterBlockCreateRemote /root/gluster-block/rpc/block_svc_routines.c:960 gluster#4 0x7fe4b076858d in start_thread (/lib64/libpthread.so.0+0x858d) Direct leak of 396 byte(s) in 18 object(s) allocated from: #0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08) gluster#1 0x7fe4b04478c7 in _IO_vasprintf (/lib64/libc.so.6+0x7a8c7) Direct leak of 32 byte(s) in 2 object(s) allocated from: #0 0x7fe4b0883c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08) gluster#1 0x7fe4b05a6bb9 in __rpc_uaddr2taddr_af (/lib64/libtirpc.so.3+0x13bb9) SUMMARY: AddressSanitizer: 17704 byte(s) leaked in 38 allocation(s). Signed-off-by: Prasanna Kumar Kalever <[email protected]>