Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-cli to v3.6.1 #898

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Update ember-cli to v3.6.1 #898

merged 2 commits into from
Jan 4, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 4, 2019

similar to #883, but hopefully this time it passes, now that #895 was merged

@Turbo87
Copy link
Member Author

Turbo87 commented Jan 4, 2019

nope... still a problem 🙈

@Turbo87
Copy link
Member Author

Turbo87 commented Jan 4, 2019

looks like it's caused by

    at AssetPrinterSize.findFiles (/Users/tbieniek/Code/glimmer-vm/node_modules/ember-cli/lib/models/asset-size-printer.js:84:14)

@Turbo87
Copy link
Member Author

Turbo87 commented Jan 4, 2019

most likely caused by ember-cli/ember-cli#8086 as walk-sync does not handle circular symlinks in any way.

/cc @stefanpenner @rwjblue

@rwjblue
Copy link
Member

rwjblue commented Jan 4, 2019

Interesting! Good catch @Turbo87!

@rwjblue
Copy link
Member

rwjblue commented Jan 4, 2019

Would you mind reporting the circular symlink issue over on walk-sync?

@rwjblue
Copy link
Member

rwjblue commented Jan 4, 2019

I think you can also work around here for now by suppressing the asset size printer output:

ember build -prod --suppress-sizes

@rwjblue rwjblue merged commit e8e669f into glimmerjs:master Jan 4, 2019
@Turbo87 Turbo87 deleted the cli-3.6 branch February 15, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants