Fix internal dependency declarations #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Dec 24, 2018
There was a problem hiding this comment.
SERIALIZATION_FIRST_NODE_STRING and isSerializationFirstNode are used in Ember, moving them is “fine” but is a breaking change (so we’d need to label appropriately) and we need to ensure that they are reexported from the top level index.ts so that we can grab them...
Turbo87
force-pushed
the
dependencies
branch
from
59773ad to
ad9a416
Compare
rwjblue
approved these changes
Dec 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some dependencies are unused, some were missing, and some were creating cycles when fixed... this was not a problem so far, but will be a problem after updating to TypeScript 3.x.