-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying capitalized version of country code when accessing I18n configuration data #336
Closed
Foozie3Moons
wants to merge
5
commits into
glebm:master
from
Foozie3Moons:fix-rails-i18n-5-1-3-locale-bug
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
df330ad
trying capitalized version of country code before returning Set if th…
c909e3b
satisfying rubocop around frozen string literals
f882697
adding tests for #required_plural_keys_for_locale(locale) regarding l…
3f1e2e9
satisfying rubocop around configuration hash style guides
89d7af2
fixing bug in new code using string key instead of symbol; not sendin…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'spec_helper' | ||
|
||
RSpec.describe 'MissingKeys' do | ||
describe '#required_plural_keys_for_locale(locale)' do | ||
let(:task) { ::I18n::Tasks::BaseTask.new } | ||
|
||
def configuration_from(locale) | ||
{ | ||
"#{locale}": { | ||
i18n: { | ||
plural: { | ||
keys: %i[one other], | ||
rule: -> {} | ||
} | ||
} | ||
} | ||
} | ||
end | ||
|
||
context 'when country code is lowercase' do | ||
let(:locale) { 'en-gb' } | ||
let(:configuration) { configuration_from(locale) } | ||
|
||
before do | ||
allow(task).to receive(:load_rails_i18n_pluralization!).with(locale).and_return(configuration) | ||
end | ||
|
||
it 'accesses the capitalized country code key and returns a populated set' do | ||
expect(task.required_plural_keys_for_locale(locale)).not_to be_empty | ||
end | ||
end | ||
|
||
context 'when country code is uppercase' do | ||
let(:locale) { 'en-GB' } | ||
let(:configuration) { configuration_from(locale) } | ||
|
||
before do | ||
allow(task).to receive(:load_rails_i18n_pluralization!).with(locale.downcase).and_return(configuration) | ||
end | ||
|
||
it 'accesses the capitalized country code key and returns a populated set' do | ||
expect(task.required_plural_keys_for_locale(locale.downcase)).not_to be_empty | ||
end | ||
end | ||
|
||
context 'when locale is not present in configuration hash' do | ||
let(:locale) { 'zz-zz' } | ||
let(:configuration) { configuration_from('en-us') } | ||
|
||
before do | ||
allow(task).to receive(:load_rails_i18n_pluralization!).with(locale).and_return(configuration) | ||
end | ||
|
||
it 'returns an empty set' do | ||
expect(task.required_plural_keys_for_locale(locale)).to be_empty | ||
end | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second group can be 3 letters, e.g. https://github.com/svenfuchs/rails-i18n/blob/254b1b43730cde87a727b83b569c08fc59b7e3fa/rails/locale/zh-YUE.yml