Trying capitalized version of country code when accessing I18n configuration data #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2019 12:43
…e key is missing from the I18n configuraiton hash
|
Please add a test |
|
Will do. |
added 2 commits
November 15, 2019 14:19
|
Should be good to go, is this test coverage for this satisfactory? |
glebm
reviewed
Nov 15, 2019
glebm
reviewed
Nov 15, 2019
…g upcase country code in alternate locale method; tests to reflect the intended behavior
Foozie3Moons
force-pushed
the
fix-rails-i18n-5-1-3-locale-bug
branch
from
ea099d3 to
89d7af2
Compare
glebm
reviewed
Nov 15, 2019
| end | ||
|
|
||
| def alternate_locale_from(locale) | ||
| re = /(\w{2})-*(\w{2})*/ |
There was a problem hiding this comment.
The second group can be 3 letters, e.g. https://github.com/svenfuchs/rails-i18n/blob/254b1b43730cde87a727b83b569c08fc59b7e3fa/rails/locale/zh-YUE.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix described in issue #335