Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the variable g:started_by_firenvim does not exist when firenvim is started? #315

Closed
jdhao opened this issue Jan 1, 2020 · 5 comments · Fixed by #316
Closed

the variable g:started_by_firenvim does not exist when firenvim is started? #315

jdhao opened this issue Jan 1, 2020 · 5 comments · Fixed by #316

Comments

@jdhao
Copy link

jdhao commented Jan 1, 2020

  • OS Version: win x86-64
  • Browser Version: Google Inc. Chrome 79.0.3945.88
  • Browser Addon Version: 0.1.17
  • Neovim Plugin Version: 0.1.17
  • What I tried to do: It seems that the variable g:started_by_firenvim does not exist.
  • What happened: when firenvim is started inside the textarea, echo g:started_by_firenvim does not exist.

image

@alerque
Copy link
Contributor

alerque commented Jan 1, 2020

Yes it does, here I will :echo g:started_by_firenvim:

image

Do you perhaps have some persistent nvim session it's connecting to that was started up another way?

@jdhao
Copy link
Author

jdhao commented Jan 1, 2020

Note that I am using a Windows machine, I checked the firenvim code and found that g:started_by_firenvim is only set when the platform is not Windows, as indicated by code here.

Is there anything that I am missing here?

@alerque
Copy link
Contributor

alerque commented Jan 1, 2020

That looks like an oversight and a relatively easy fix!

@glacambre
Copy link
Owner

glacambre commented Jan 1, 2020

I fixed this issue and implemented a test to make sure this feature keeps working. Please update the neovim plugin run firenvim#install() again and let me know if everything works as expected.

Thank you for reporting this bug :).

@jdhao
Copy link
Author

jdhao commented Jan 1, 2020

Thanks, I have updated to the latest version of firenvim, and it is working great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants