g:started_by_firenvim is not set on windows

[BlueDrink9]

Sorry, me again.

• OS Version: win x86-64
• Browser Version: Google Inc. Chrome 79.0.3945.130
• Browser Addon Version: 0.1.17
• Neovim Plugin Version: 0.1.17
• What I tried to do: Change config when started by firenvim
• What happened: No config changed, echom g:started_by_firenvim gives undefined variable error.

[glacambre]

Duplicate of #315 . Try updating the neovim plugin and running firenvim#install again :)

[BlueDrink9]

Oops sorry. Thanks

[BlueDrink9]

Hmm, doesn't seem to have worked, even after updating.

Ah, but I see you haven't released the relevant commit yet. I'll wait on that.

Are releases automatic? (Done on CI?) If not, would you be interested in having it set up?

[glacambre]

Ah, but I see you haven't released the relevant commit yet. I'll wait on that.

This shouldn't matter for the neovim plugin. Could you run firenvim#uninstall and firenvim#install again? Perhaps, while your browser is closed? If this still doesn't work, could you upload the content of the firenvim script here?

Are releases automatic?

No, they aren't, they require manually uploading files to the chrome & firefox stores. I haven't checked if there were APIs to do that though.

[BlueDrink9]

To clarify, I'm only pulling tags, to make sure my firenvim version is never ahead of release versions. If you want I can manually pull the new one, or if you think there are no downsides I'll change back to pulling from master.

[glacambre]

Only pulling tags isn't a bad idea (there shouldn't be any issues with using master but I don't pay an enormous amount of attention to compatibility, so it's better to be safe than sorry :)). I released v0.1.18 a few hours ago, it should reach the chrome web store in a few days, let's wait until that happens and see if the issue persists :)

[BlueDrink9]

Thank you!

[BlueDrink9]

Old article, but looks like CI deployment is possible for chrome. Firefox should be possible too, but may have issues with signing. (These are being addressed.)