Provide an accessible git askyesno and use is in git update-git-for-windows
#234
Conversation
|
@sukiletxe please do have a look. Here is a build of the new executable: Just like Can you please test this and verify that it is accessible? |
|
This is starting to be a thing that I'm working on preparing a PR and you're slightly faster, isn't it? Well, guess I'll review it. |
|
@rimrul sorry!!! ;-) |
|
You had better equipment this time round anyways. I couln't have compiled the WinAPI parts atm. |
|
I confirm it works correctly. Thank you very much! |
|
Though I believe |
You mean in This PR won't change what |
@sukiletxe thank you! |
Indeed. If it wasn't for existing callers. We ship |
This is a drop-in replacement for `git gui--askyesno` that is hopefully accessible out of the box. Signed-off-by: Johannes Schindelin <[email protected]>
We are trying to come up with a drop-in replacement for `git gui--askyesno` because that command is not accessible (read: a screen reader cannot make sense of it). To make it a true drop-in replacement, we also need to imitate how `git gui--askyesno` accepted multiple command-line parameters and simply joined them into a single string. Signed-off-by: Johannes Schindelin <[email protected]>
When we ask whether the user is ready to install an update, we use a graphical popup. So far, we used `git gui--askyesno`, which was convenient because it was small, and we ship with Tcl/Tk anyway. However, that GUI helper is not nice to screen readers, making it inaccessible. We just introduced a drop-in replacement that is accessible, let's use that one instead. This fixes git-for-windows/git#2099 Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
accessible-git-askyesno
branch
from
4e80662 to
80f5a6a
Compare
dscho
changed the title
git askyesnogit askyesno and use is in git update-git-for-windows
Git for Windows' updater [is now accessible](#234), i.e. it can be read by a screen reader. Signed-off-by: Johannes Schindelin <[email protected]>
This is a drop-in replacement for `git gui--askpass`. Since we added an option to use an external `ssh` found on the `PATH` (git-for-windows#367) we'll need an `askpass` implementation that can be called by any windows application even without understanding shebang lines. `git gui--askpass` probably also has the same problems with screenreaders that `git gui--askyesno` had(git-for-windows#234), so we'll likely get improved accessibility as a positive side-effect. Signed-off-by: Matthias Aßhauer <[email protected]>
This is a drop-in replacement for `git gui--askpass`. Since we added an option to use an external `ssh` found on the `PATH` (git-for-windows#367) we'll need an `askpass` implementation that can be called by any windows application even without understanding shebang lines. `git gui--askpass` probably also has the same problems with screenreaders that `git gui--askyesno` had(git-for-windows#234), so we'll likely get improved accessibility as a positive side-effect. Signed-off-by: Matthias Aßhauer <[email protected]>
This is a drop-in replacement for `git gui--askpass`. Since we added an option to use an external `ssh` found on the `PATH` (git-for-windows#367) we'll need an `askpass` implementation that can be called by any windows application even without understanding shebang lines. `git gui--askpass` probably also has the same problems with screenreaders that `git gui--askyesno` had(git-for-windows#234), so we'll likely get improved accessibility as a positive side-effect. Signed-off-by: Matthias Aßhauer <[email protected]>
It was reported in git-for-windows/git#2099 that our updater is not accessible, but what is actually not accessible is that Tcl/Tk script we use to ask the question.
This is (sadly!) the first time I was made aware that this script, that we introduced a long, long time ago, makes it hard/impossible to use with screenreaders.
Let's fix that.