Skip to content

Commit 80f5a6a

Browse files
committed
git update-git-for-windows: use accessible popup
When we ask whether the user is ready to install an update, we use a graphical popup. So far, we used `git gui--askyesno`, which was convenient because it was small, and we ship with Tcl/Tk anyway. However, that GUI helper is not nice to screen readers, making it inaccessible. We just introduced a drop-in replacement that is accessible, let's use that one instead. This fixes git-for-windows/git#2099 Signed-off-by: Johannes Schindelin <[email protected]>
1 parent e736197 commit 80f5a6a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

git-extra/PKGBUILD

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ sha256sums=('9efaf8dccc08c7cddc58cb589bab5aac5c0894661175a344ca02b2aa849382bd'
7070
'37e3412480f0fc5b742406d569baa1a6c572f5be16650ae70c65169c5fd4a8e3'
7171
'd05f507c7706642c0fe491d3a5b130666a38ceb8d0263be5d21b631f2d890b5d'
7272
'0df1de94f20047a854d1e201597c3d4ebcc5f7389f272fb031f7424de009e19a'
73-
'591d64c5b906cb315bafd5c157c5a9286d1ba3ce54be121ddecfa4ab3607ed93'
73+
'8789aa76ce7ed6846643e19b41924dd14efb32be195ddb98e8badc11934c6c73'
7474
'15b40ab72dea884f659cfbe441e9a40b2d8d63e490a3c14824a55607368e476d'
7575
'ebd1d20aa94be11c6b9bec7d33614d32016343d282c4716d0561ab41407c99bf'
7676
'97e89689d91747ddb5ee873ae864aebcbb8d0364a52fa198db1e439ee2965b9b'

git-extra/git-update-git-for-windows

+2-2
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ update_git_for_windows () {
221221
# toast not activated, failed, toasts
222222
# unsupported, WinToast init failed or toast
223223
# not launched: fall back to using GUI
224-
git gui--askyesno \
224+
git askyesno \
225225
--title "Git Update Available" \
226226
"Download and install $name$warn?" || {
227227
git config --global \
@@ -237,7 +237,7 @@ update_git_for_windows () {
237237
esac
238238
elif test -n "$use_gui"
239239
then
240-
git gui--askyesno --title "Git Update Available" \
240+
git askyesno --title "Git Update Available" \
241241
"Download and install $name$warn?" || {
242242
git config --global \
243243
winUpdater.recentlySeenVersion "$latest"

0 commit comments

Comments
 (0)