Treat empty proxy settings as a signal to _not_ use a proxy #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When proxy settings are set in Git, an empty value is treated as "do not use a proxy". We update GCM to do the same thing; when an empty value is set, we do not use a proxy. This allows for the scenario where a proxy has been set globally (unscoped) but a specific (scoped) remote does NOT have a proxy set.
mjcheetham
requested review from
vdye,
jeffhostetler,
derrickstolee and
ldennington
vdye
approved these changes
Sep 13, 2021
derrickstolee
approved these changes
Sep 13, 2021
This was referenced Oct 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When proxy settings are set in Git, an empty value is treated as "do not use a proxy". We update GCM to do the same thing; when an empty value is set, we do not use a proxy.
This allows for the scenario where a proxy has been set globally (unscoped) but a specific (scoped) remote does NOT have a proxy set.
Fixes #442